Skip to content

[Clang][Sema] placement new initializes typedef array with correct size #88902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024
Merged

[Clang][Sema] placement new initializes typedef array with correct size #88902

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
751fd34
[Clang][Sema] placement new initializes typedef array with correct size
mahtohappy Apr 16, 2024
517ff20
build trigger
mahtohappy Apr 16, 2024
de034e9
build fix
mahtohappy Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...emaCXX/instantiate-new-placement-size.cpp → clang/test/SemaCXX/PR41441.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
// Issue no: 41441
// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s

#include <new>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This #include is also possible to cause breakages, you should just put hte important declarations in text.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does:

https://lab.llvm.org/buildbot/#/builders/280/builds/1989

/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/clang/test/SemaCXX/PR41441.cpp:3:10: fatal error: 'new' file not found
    3 | #include <new>
      |          ^~~~~
1 error generated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blarg, the buildbots i checked on were mangling differences. I'll fix this locally as I suggested and get a fix merged ASAP.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good as of 0a789ea

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


// CHECK: call void @llvm.memset.p0.i64(ptr align 1 %x, i8 0, i64 8, i1 false)
Expand Down