-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[Pipelines] Do not run CoroSplit and CoroCleanup in LTO pre-link pipeline #90310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| // This tests that the coroutine elide optimization could happen succesfully with ThinLTO. | ||
| // This test is adapted from coro-elide.cpp and splits functions into two files. | ||
| // | ||
| // RUN: split-file %s %t | ||
| // RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto=thin -I %S -c %t/coro-elide-callee.cpp -o coro-elide-callee.o | ||
| // RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto=thin -I %S -c %t/coro-elide-caller.cpp -o coro-elide-caller.o | ||
| // RUN: llvm-lto -thinlto coro-elide-callee.o coro-elide-caller.o -o summary | ||
| // RUN: %clang_cc1 -O2 -x ir coro-elide-caller.o -fthinlto-index=summary.thinlto.bc -emit-llvm -o - | FileCheck %s | ||
|
|
||
| //--- coro-elide-task.h | ||
| #pragma once | ||
| #include "Inputs/coroutine.h" | ||
|
|
||
| struct Task { | ||
| struct promise_type { | ||
| struct FinalAwaiter { | ||
| bool await_ready() const noexcept { return false; } | ||
| template <typename PromiseType> | ||
| std::coroutine_handle<> await_suspend(std::coroutine_handle<PromiseType> h) noexcept { | ||
| if (!h) | ||
| return std::noop_coroutine(); | ||
| return h.promise().continuation; | ||
| } | ||
| void await_resume() noexcept {} | ||
| }; | ||
| Task get_return_object() noexcept { | ||
| return std::coroutine_handle<promise_type>::from_promise(*this); | ||
| } | ||
| std::suspend_always initial_suspend() noexcept { return {}; } | ||
| FinalAwaiter final_suspend() noexcept { return {}; } | ||
| void unhandled_exception() noexcept {} | ||
| void return_value(int x) noexcept { | ||
| _value = x; | ||
| } | ||
| std::coroutine_handle<> continuation; | ||
| int _value; | ||
| }; | ||
|
|
||
| Task(std::coroutine_handle<promise_type> handle) : handle(handle) {} | ||
| ~Task() { | ||
| if (handle) | ||
| handle.destroy(); | ||
| } | ||
|
|
||
| struct Awaiter { | ||
| bool await_ready() const noexcept { return false; } | ||
| void await_suspend(std::coroutine_handle<void> continuation) noexcept {} | ||
| int await_resume() noexcept { | ||
| return 43; | ||
| } | ||
| }; | ||
|
|
||
| auto operator co_await() { | ||
| return Awaiter{}; | ||
| } | ||
|
|
||
| private: | ||
| std::coroutine_handle<promise_type> handle; | ||
| }; | ||
|
|
||
| //--- coro-elide-callee.cpp | ||
| #include "coro-elide-task.h" | ||
| Task task0() { | ||
| co_return 43; | ||
| } | ||
|
|
||
| //--- coro-elide-caller.cpp | ||
| #include "coro-elide-task.h" | ||
|
|
||
| Task task0(); | ||
|
|
||
| Task task1() { | ||
| co_return co_await task0(); | ||
| } | ||
|
|
||
| // CHECK-LABEL: define{{.*}} void @_Z5task1v.resume | ||
| // CHECK-NOT: {{.*}}_Znwm | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case requires an X86 backend. Those of us who have embraced the AArch64-only future are encountering test errors when running this test.
(maybe it's just me)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just landed #90672 to limit the test to x86 linux targets. Did that fix the test failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Thank you for the quick fix.