Skip to content

[Coroutines][Test] Only run coro-elide-thinlto under x86_64-linux #90672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2024

Conversation

apolloww
Copy link
Contributor

Previous fix #90549 didn't completely address the Buildbot failures. Some target may not recognize the target triple. This time, only run the test under x86_64-linux.

@llvmbot llvmbot added clang Clang issues not falling into any other category coroutines C++20 coroutines labels Apr 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 30, 2024

@llvm/pr-subscribers-clang

Author: Wei Wang (apolloww)

Changes

Previous fix #90549 didn't completely address the Buildbot failures. Some target may not recognize the target triple. This time, only run the test under x86_64-linux.


Full diff: https://github.com/llvm/llvm-project/pull/90672.diff

1 Files Affected:

  • (modified) clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp (+1)
diff --git a/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp b/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
index d0e60e67963dfd..5b2d0146578437 100644
--- a/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
+++ b/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: x86_64-linux
 // This tests that the coroutine elide optimization could happen succesfully with ThinLTO.
 // This test is adapted from coro-elide.cpp and splits functions into two files.
 //

@llvmbot
Copy link
Member

llvmbot commented Apr 30, 2024

@llvm/pr-subscribers-coroutines

Author: Wei Wang (apolloww)

Changes

Previous fix #90549 didn't completely address the Buildbot failures. Some target may not recognize the target triple. This time, only run the test under x86_64-linux.


Full diff: https://github.com/llvm/llvm-project/pull/90672.diff

1 Files Affected:

  • (modified) clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp (+1)
diff --git a/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp b/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
index d0e60e67963dfd..5b2d0146578437 100644
--- a/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
+++ b/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
@@ -1,3 +1,4 @@
+// REQUIRES: x86_64-linux
 // This tests that the coroutine elide optimization could happen succesfully with ThinLTO.
 // This test is adapted from coro-elide.cpp and splits functions into two files.
 //

@apolloww
Copy link
Contributor Author

https://lab.llvm.org/buildbot/#/builders/188/builds/45187

Error running ThinLTO backend: No available targets are compatible with triple "x86_64-unknown-linux"

@dyung
Copy link
Collaborator

dyung commented May 1, 2024

This test has been failing on bots for several hours now. Can we either get this fix in or the original change reverted to get the bots back to green? One failing bot is https://lab.llvm.org/buildbot/#/builders/280/builds/2876.

@apolloww
Copy link
Contributor Author

apolloww commented May 1, 2024

This test has been failing on bots for several hours now. Can we either get this fix in or the original change reverted to get the bots back to green? One failing bot is https://lab.llvm.org/buildbot/#/builders/280/builds/2876.

sorry for the breakage, the same fix is included in #90690. Will land shortly.

@apolloww apolloww merged commit b1b1bfa into llvm:main May 1, 2024
@apolloww apolloww deleted the fix-coro-thinlto-test_again branch May 1, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category coroutines C++20 coroutines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants