Skip to content

[Coroutines][Test] Specify target triple in coro-elide-thinlto #90549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

apolloww
Copy link
Contributor

Resolve test failure on non-x86 linux host

@llvmbot llvmbot added clang Clang issues not falling into any other category coroutines C++20 coroutines labels Apr 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Apr 30, 2024

@llvm/pr-subscribers-coroutines

@llvm/pr-subscribers-clang

Author: Wei Wang (apolloww)

Changes

Resolve test failure on non-x86 linux host


Full diff: https://github.com/llvm/llvm-project/pull/90549.diff

1 Files Affected:

  • (modified) clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp (+1-1)
diff --git a/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp b/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
index 293aef6781677f..50e8648a09d450 100644
--- a/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
+++ b/clang/test/CodeGenCoroutines/coro-elide-thinlto.cpp
@@ -5,7 +5,7 @@
 // RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto=thin -I %S -c %t/coro-elide-callee.cpp -o coro-elide-callee.o
 // RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto=thin -I %S -c %t/coro-elide-caller.cpp -o coro-elide-caller.o
 // RUN: llvm-lto -thinlto coro-elide-callee.o coro-elide-caller.o -o summary
-// RUN: %clang_cc1 -O2 -x ir coro-elide-caller.o -fthinlto-index=summary.thinlto.bc -emit-llvm -o - | FileCheck %s
+// RUN: %clang_cc1 -triple x86_64-unknown-linux -O2 -x ir coro-elide-caller.o -fthinlto-index=summary.thinlto.bc -emit-llvm -o - | FileCheck %s
 
 //--- coro-elide-task.h
 #pragma once

@apolloww
Copy link
Contributor Author

This should make Buildbot failure like https://lab.llvm.org/buildbot/#/builders/38/builds/19079 to go away

warning: linking module 'coro-elide-caller.o': Linking two modules of different target triples: 'coro-elide-callee.o' is 'x86_64-unknown-linux' whereas 'coro-elide-caller.o' is 'hexagon-unknown-unknown-elf'

@apolloww apolloww force-pushed the fix-coro-thinlto-test branch from 4cdba51 to 1fac468 Compare April 30, 2024 03:13
@apolloww apolloww merged commit 0232b77 into llvm:main Apr 30, 2024
apolloww added a commit that referenced this pull request May 1, 2024
…0672)

Previous fix #90549 didn't completely address the Buildbot failures.
Some target may not recognize the target triple. This time, only run the
test under x86_64-linux.
@apolloww apolloww deleted the fix-coro-thinlto-test branch May 1, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category coroutines C++20 coroutines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants