-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[MIR] Serialize MachineFrameInfo::isCalleeSavedInfoValid() #90561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIR] Serialize MachineFrameInfo::isCalleeSavedInfoValid() #90561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a parsing test where this is true. Can you also add one that hit the issue you described? Can we just print the empty list in this case?
That wouldn't help because the logic in MIRParser would still not find any callee-saved info and set it as not valid. |
Would an empty stack list, |
Oh yes, testing is no issue. I understood the question as can't we omit |
b9033e3
to
9eec28c
Compare
Added a test that should cover all combinations of having a stack or not and having valid callee-saved info or not. |
9eec28c
to
a58a346
Compare
Sure, the newly added test is failing because |
e0e9cb8
to
48fe7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In case of functions without a stack frame no "stack" field is serialized into MIR which leads to isCalleeSavedInfoValid being false when reading a MIR file back in. To fix this we should serialize MachineFrameInfo::isCalleeSavedInfoValid() into MIR.
48fe7a8
to
3586507
Compare
In case of functions without a stack frame no "stack" field is serialized into MIR which leads to isCalleeSavedInfoValid being false when reading a MIR file back in. To fix this we should serialize MachineFrameInfo::isCalleeSavedInfoValid() into MIR.