[lldb][Windows] Fixed the test TestGdbRemoteMemoryTagging

[slydiman]

Windows path is case insensitive. Tests test_QMemTags_packets and test_qMemTags_packets will use the same build dir and conflict. Added a suffix to resolve conflicts.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

Windows path is case insensitive. Tests test_QMemTags_packets and test_qMemTags_packets will use the same build dir and conflict. Added a suffix to resolve conflicts.

---

Full diff: https://github.com/llvm/llvm-project/pull/92077.diff

1 Files Affected:

• (modified) lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py (+2-2)

diff --git a/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py b/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py
index 584de5e2ef49e..e14c7b4a39d58 100644
--- a/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py
+++ b/lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py
@@ -84,7 +84,7 @@ def prep_memtags_test(self):
     @skipUnlessArch("aarch64")
     @skipUnlessPlatform(["linux"])
     @skipUnlessAArch64MTELinuxCompiler
-    def test_qMemTags_packets(self):
+    def test_qMemTags_packets_A(self):
         """Test that qMemTags packets are parsed correctly and/or rejected."""
         buf_address, page_size = self.prep_memtags_test()
 
@@ -154,7 +154,7 @@ def check_tag_write(self, body, expected):
     @skipUnlessArch("aarch64")
     @skipUnlessPlatform(["linux"])
     @skipUnlessAArch64MTELinuxCompiler
-    def test_QMemTags_packets(self):
+    def test_QMemTags_packets_B(self):
         """Test that QMemTags packets are parsed correctly and/or rejected."""
         buf_address, page_size = self.prep_memtags_test()
 

[DavidSpickett]

I've seen this with a packet test before, the GDB protocol likes to use first character lower case for read and upper case for write.

https://sourceware.org/gdb/current/onlinedocs/gdb.html/General-Query-Packets.html

So yes let's change the name but how about this instead:

test_tag_read_qMemTags_packets
test_tag_write_QMemTags_packets

Then it's clearer why there are 2 tests.

[slydiman]

Done.