Skip to content

[lldb] Fixed the DAP tests in case of a remote target #92416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2024

Conversation

slydiman
Copy link
Contributor

These tests are based on dap_server which runs locally. These tests failed in case of Windows host and Linux target.

These tests are based on dap_server which runs locally. These tests failed in case of Windows host and Linux target.
@slydiman slydiman requested a review from JDevlieghere as a code owner May 16, 2024 15:42
@llvmbot llvmbot added the lldb label May 16, 2024
@slydiman slydiman requested review from labath and DavidSpickett May 16, 2024 15:42
@llvmbot
Copy link
Member

llvmbot commented May 16, 2024

@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)

Changes

These tests are based on dap_server which runs locally. These tests failed in case of Windows host and Linux target.


Full diff: https://github.com/llvm/llvm-project/pull/92416.diff

2 Files Affected:

  • (modified) lldb/test/API/tools/lldb-dap/completions/TestDAP_completions.py (+1)
  • (modified) lldb/test/API/tools/lldb-dap/exception/TestDAP_exception.py (+1)
diff --git a/lldb/test/API/tools/lldb-dap/completions/TestDAP_completions.py b/lldb/test/API/tools/lldb-dap/completions/TestDAP_completions.py
index 2b3ec656c107a..3250a5093cac4 100644
--- a/lldb/test/API/tools/lldb-dap/completions/TestDAP_completions.py
+++ b/lldb/test/API/tools/lldb-dap/completions/TestDAP_completions.py
@@ -19,6 +19,7 @@ def verify_completions(self, actual_list, expected_list, not_expected_list=[]):
             self.assertNotIn(not_expected_item, actual_list)
 
     @skipIfWindows
+    @skipIfRemote
     @skipIf(compiler="clang", compiler_version=["<", "17.0"])
     def test_completions(self):
         """
diff --git a/lldb/test/API/tools/lldb-dap/exception/TestDAP_exception.py b/lldb/test/API/tools/lldb-dap/exception/TestDAP_exception.py
index 8c2c0154ba65c..58a67d8164368 100644
--- a/lldb/test/API/tools/lldb-dap/exception/TestDAP_exception.py
+++ b/lldb/test/API/tools/lldb-dap/exception/TestDAP_exception.py
@@ -9,6 +9,7 @@
 
 
 class TestDAP_exception(lldbdap_testcase.DAPTestCaseBase):
+    @skipIfRemote
     @skipIfWindows
     def test_stopped_description(self):
         """

@slydiman slydiman merged commit c7ae8c6 into llvm:main May 16, 2024
6 checks passed
@labath
Copy link
Collaborator

labath commented May 17, 2024

Are all lldb-dap tests not compatible with running remotely? If so, then instead of annotating them individually, we could tag them all with some "dap" category (if they're not already) and then automatically skip that category when running remotely.

@walter-erquinigo
Copy link
Member

That's a great idea. There's no such dap category at the moment, but it would be nice if such category is created as part of the ongoing lldb-dap test fixes.

@slydiman slydiman deleted the fix-lldb-dap-tests2 branch July 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants