[compiler-rt][memprof] Do not add libdl to MEMPROF_UNITTEST_LINK_LIBRARIES

[alexander-shaposhnikov]

The memprof tests do not actually depend on libdl.
They might have a transitive dependency on libdl through the runtime, but the runtime takes care of itself.
Based on the offline discussions it looks like this piece of code in cmake is a historical artifact.

Test plan: ninja check-all

[llvmbot]

@llvm/pr-subscribers-pgo

Author: Alexander Shaposhnikov (alexander-shaposhnikov)

Changes

The memprof tests do not actually depend on libdl.
They might have a transitive dependency on libdl through the runtime, but the runtime takes care of itself.
Based on the offline discussions it looks like this piece of code in cmake is a historical artifact.

Test plan: ninja check-all

---

Full diff: https://github.com/llvm/llvm-project/pull/98221.diff

1 Files Affected:

• (modified) compiler-rt/lib/memprof/tests/CMakeLists.txt (-1)

diff --git a/compiler-rt/lib/memprof/tests/CMakeLists.txt b/compiler-rt/lib/memprof/tests/CMakeLists.txt
index 0b5c302a4ce5d..a35f12bc14265 100644
--- a/compiler-rt/lib/memprof/tests/CMakeLists.txt
+++ b/compiler-rt/lib/memprof/tests/CMakeLists.txt
@@ -49,7 +49,6 @@ endif()
 set(MEMPROF_UNITTEST_LINK_LIBRARIES
   ${COMPILER_RT_UNWINDER_LINK_LIBS}
   ${SANITIZER_TEST_CXX_LIBRARIES})
-append_list_if(COMPILER_RT_HAS_LIBDL -ldl MEMPROF_UNITTEST_LINK_LIBRARIES)
 
 # Adds memprof tests for each architecture.
 macro(add_memprof_tests_for_arch arch)

[chapuni]

This fails linking MemProfTests on Linux.

sanitizer_linux_libcdep.cpp uses dlsym but sanitizer_common doesn't provide deps on -ldl.

[arichardson]

As far as I recall libdl is only needed for dl_iterate_phdrs which is used by some sanitizers (and won't be pulled in implicitly for static linking), but if memprof does not need it we can defintely drop it.