Skip to content

[compiler-rt][nsan] cmake cleanup #98224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexander-shaposhnikov
Copy link
Collaborator

CMake cleanup.
P.S. See also #98221 .

@llvmbot
Copy link
Member

llvmbot commented Jul 9, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Alexander Shaposhnikov (alexander-shaposhnikov)

Changes

CMake cleanup.
P.S. See also #98221 .


Full diff: https://github.com/llvm/llvm-project/pull/98224.diff

1 Files Affected:

  • (modified) compiler-rt/lib/nsan/tests/CMakeLists.txt (-3)
diff --git a/compiler-rt/lib/nsan/tests/CMakeLists.txt b/compiler-rt/lib/nsan/tests/CMakeLists.txt
index 3d962e70a7bf0..e472fc5c06f90 100644
--- a/compiler-rt/lib/nsan/tests/CMakeLists.txt
+++ b/compiler-rt/lib/nsan/tests/CMakeLists.txt
@@ -23,9 +23,6 @@ set(NSAN_UNITTESTS
 
 add_custom_target(NsanUnitTests)
 
-# set(NSAN_UNITTEST_LINK_FLAGS ${COMPILER_RT_UNITTEST_LINK_FLAGS} -ldl)
-# list(APPEND NSAN_UNITTEST_LINK_FLAGS --driver-mode=g++)
-
 if(COMPILER_RT_DEFAULT_TARGET_ARCH IN_LIST NSAN_SUPPORTED_ARCH)
   # NSan unit tests are only run on the host machine.
   set(arch ${COMPILER_RT_DEFAULT_TARGET_ARCH})

@alexander-shaposhnikov alexander-shaposhnikov merged commit 1c6bc04 into llvm:main Jul 10, 2024
9 checks passed
aaryanshukla pushed a commit to aaryanshukla/llvm-project that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants