[HIP] Adds GTest Filter for Kokkos #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filters-out two tests that are currently failing.
mhalk
approved these changes
Apr 1, 2025
| @@ -141,7 +141,7 @@ macro(create_hip_tests) | |||
| ) | |||
| add_custom_target(build-kokkos DEPENDS TestKokkosHIP) | |||
| ExternalProject_Get_Property(TestKokkosHIP BINARY_DIR) | |||
| add_custom_target(test-kokkos COMMAND "ctest" WORKING_DIRECTORY "${BINARY_DIR}" DEPENDS build-kokkos) | |||
| add_custom_target(test-kokkos ${CMAKE_COMMAND} -E env GTEST_FILTER=-hip.atomics:hip.bit_manip_bit_ceil "ctest" WORKING_DIRECTORY "${BINARY_DIR}" DEPENDS build-kokkos) | |||
There was a problem hiding this comment.
Is COMMAND obsolete here?
Would have expected to see: COMMAND ${CMAKE_COMMAND} -E [...]
There was a problem hiding this comment.
The honest answer is that I don't know. This is how I found it for the "Command Line Tool Mode" (https://cmake.org/cmake/help/latest/manual/cmake.1.html#run-a-command-line-tool), which appears to be the way how to do it when you want to run a command and change the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filters-out two tests that are currently failing.