Skip to content

[HIP] Adds GTest Filter for Kokkos #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

[HIP] Adds GTest Filter for Kokkos #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion External/HIP/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ macro(create_hip_tests)
)
add_custom_target(build-kokkos DEPENDS TestKokkosHIP)
ExternalProject_Get_Property(TestKokkosHIP BINARY_DIR)
add_custom_target(test-kokkos COMMAND "ctest" WORKING_DIRECTORY "${BINARY_DIR}" DEPENDS build-kokkos)
add_custom_target(test-kokkos ${CMAKE_COMMAND} -E env GTEST_FILTER=-hip.atomics:hip.bit_manip_bit_ceil "ctest" WORKING_DIRECTORY "${BINARY_DIR}" DEPENDS build-kokkos)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is COMMAND obsolete here?
Would have expected to see: COMMAND ${CMAKE_COMMAND} -E [...]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The honest answer is that I don't know. This is how I found it for the "Command Line Tool Mode" (https://cmake.org/cmake/help/latest/manual/cmake.1.html#run-a-command-line-tool), which appears to be the way how to do it when you want to run a command and change the environment.

endif()

if (EXTERNAL_HIP_TESTS_GINKGO)
Expand Down