Skip to content

[flang] Scrub lists of failing tests in DisabledFiles.cmake #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

klausler
Copy link
Contributor

@klausler klausler commented Dec 11, 2023

Remove many tests from Fortran/gfortran/regression/DisabledFiles.cmake that now pass. Move others around from more general classifications to groups with specific diagnoses like "unimplemented feature" or "bad test".

@klausler klausler requested a review from tarunprabhu December 11, 2023 22:20
Remove many tests from Fortran/gfortran/regression/DisabledFiles.cmake
that now pass.  Move others around from more general classifications to
groups with specific diagnoses like "unimplemented feature" or "bad
test".
Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. These are passing for me on aarch64

@klausler
Copy link
Contributor Author

Tarun, any comment?

@tarunprabhu
Copy link
Contributor

Tarun, any comment?

Sorry for the delay, got tangled up with my other projects. I'll take this for a spin this afternoon.

@tarunprabhu
Copy link
Contributor

Thanks for the detailed classification. I think more tests will be removed from this list once the build system is fixed and the shouldfail tests are handled correctly.

@klausler klausler merged commit 3377a72 into llvm:main Dec 12, 2023
@klausler klausler deleted the pmk-triage branch December 12, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants