Fix Fortran tests for Windows platform #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes minor changes to ignore windows line endings when Fortran tests are run on windows platform.
tarunprabhu
reviewed
Jan 11, 2024
Comment on lines
+85
to
+86
| if (CMAKE_Fortran_COMPILER_ID STREQUAL "LLVMFlang" | ||
| AND (ARCH STREQUAL "AArch64" OR TARGET_OS STREQUAL "Windows")) |
There was a problem hiding this comment.
If I understand this correctly, the tests will be disabled on Windows on all hardware platforms and will be disabled on all OS'es on AArch64. I just want to double-check that this is what you intended?
There was a problem hiding this comment.
Yes. This fails on windows regardless of the underlying architecture. I am currently trying to enable everything which works.
|
Apologies @omjavaid, I somehow didn't see that you had requested a review from me. |
tarunprabhu
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes minor changes to ignore windows line endings when Fortran tests are run on windows platform.