Skip to content

[Fortran] Enable tests that failed when using libpgmath on AArch64 Linux #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

DavidSpickett
Copy link
Contributor

Now that we're not using libpgmath, these tests pass on AArch64.

They may work on Windows now but I don't have a build setup to check yet, and none of the builders run the test suite yet. If/when I can confirm, I'll come back and remove the Windows check too.

Now that we're not using libpgmath, these tests pass on AArch64.

They may work on Windows now but I don't have a build setup to check yet,
and none of the builders run the test suite yet. If/when I can confirm,
I'll come back and remove the Windows check too.
@DavidSpickett
Copy link
Contributor Author

Windows opt out was added in #69. @omjavaid what's the status of running the test suite on Windows, can I just use what's upstream or is there work left to do?

Copy link
Contributor

@antmox antmox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidSpickett
Copy link
Contributor Author

We'll know very quickly what the buildbots think, so I'm going to land this and follow up with Omair later for the Windows side.

@DavidSpickett DavidSpickett merged commit e3dde6f into main Feb 14, 2024
@DavidSpickett DavidSpickett deleted the pgmath branch February 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants