Fix issue #208: Add HTML <q> tag to core components #212
Conversation
There was a problem hiding this comment.
Hey @GrantBarry, thank you for the pull request! There's some minor changes as commented. Could you also change the target branch to develop? Master reflects the current version of the Gem, and we merge develop into master with a Changelog documentation every once in a while :)
Keep up the good work - and feel free to join or Gitter if you face challenges or questions arrise! https://gitter.im/basemate/community
| @@ -0,0 +1,5 @@ | |||
| module Matestack::Ui::Core::Q | |||
| class Q < Matestack::Ui::Core::Component::Static | |||
|
|
|||
There was a problem hiding this comment.
Here, you probably need to merge the cite option into @tag_attributes
| @@ -0,0 +1,3 @@ | |||
| %q{@tag_attributes} | |||
| - if block_given? | |||
There was a problem hiding this comment.
I would love this component to have a options[:text, like e.g. the paragraph or span component. Could you implement (and test & document) this?
|
|
||
| ## Parameters | ||
|
|
||
| This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param. |
There was a problem hiding this comment.
Again, the cite configuration param is missing
|
|
||
| #nested q | ||
| q do | ||
| q id: "my-nested-q" |
There was a problem hiding this comment.
Please test the text: "This is an example text cite" and cite: "www.matestack.org/example" as well :)
| ## Example 2: Render options[:text] param | ||
|
|
||
| ```ruby | ||
| q id: "foo", class: "bar", text: 'Hello World' |
There was a problem hiding this comment.
This example is not tested and for now probably wouldn't work!
|
Closed as duplicate to #216 |
Issue #208: Add HTML
Changes
Notes