Skip to content

Fix issue #208: Add HTML <q> tag to core components #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2019
Merged

Fix issue #208: Add HTML <q> tag to core components #216

merged 3 commits into from
Oct 2, 2019

Conversation

GrantBarry
Copy link
Contributor

Issue #208: Add HTML tag to core components

Changes

  • Created q folder, q.haml and q.rb files to matestack ui core components
  • Created q.md to docs > components
  • Created q_spec.rb to usage > components

Notes

  • Nothing here

@GrantBarry
Copy link
Contributor Author

Please note that I'm getting a lot of failures testing out of the box so I'm not confident with my tests.
After running 'bundle' and 'yarn install', I'm running 'bundle exec rspec'. Am I missing something?

@pascalwengerter pascalwengerter mentioned this pull request Oct 2, 2019
Closed
pascalwengerter
pascalwengerter suggested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and we're good to merge!

spec/usage/components/q_spec.rb Outdated
expected_static_output = <<~HTML
<q>A simple quote</q>

<q id="my-id" class="my-class"></q>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the empy <q> tag comes from. Please include it on the page above (between #simple and #enhanced) or remove it.

@pascalwengerter
Copy link
Contributor

Please note that I'm getting a lot of failures testing out of the box so I'm not confident with my tests.
After running 'bundle' and 'yarn install', I'm running 'bundle exec rspec'. Am I missing something?

Yeah, sadly the test suite doesn't work coherently between local machine and CircleCI. To run single tests (for example in this PR, to see whether the new component works) you can also use commands like
bundle exec rspec spec/usage/components/q_spec.rb.
Does this help?

pascalwengerter
pascalwengerter approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all good!

@pascalwengerter pascalwengerter merged commit 4ed2f62 into matestack:develop Oct 2, 2019
@pascalwengerter
Copy link
Contributor

Great work @GrantBarry, thanks for the contribution!

@pascalwengerter pascalwengerter mentioned this pull request Oct 2, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.3 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@GrantBarry @pascalwengerter @jonasjabari