-
-
Notifications
You must be signed in to change notification settings - Fork 43
Fix issue #208: Add HTML <q> tag to core components #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
%q{@tag_attributes} | ||
- if block_given? | ||
= yield | ||
- else | ||
= options[:text] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
module Matestack::Ui::Core::Q | ||
class Q < Matestack::Ui::Core::Component::Static | ||
|
||
def setup | ||
@tag_attributes.merge!({ | ||
"cite": options[:cite] | ||
}) | ||
end | ||
|
||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
# matestack core component: Q | ||
|
||
Show [specs](../../spec/usage/components/q_spec.rb) | ||
|
||
The HTML q tag implemented in ruby. | ||
|
||
## Parameters | ||
|
||
This component can take 4 optional configuration params and either yield content or display what gets passed to the `text` configuration param. | ||
|
||
#### # id (optional) | ||
Expects a string with all ids the quote should have. | ||
|
||
#### # class (optional) | ||
Expects a string with all classes the quote should have. | ||
|
||
#### # text (optional) | ||
Expects a string with the text that should go into the `<q>` tag. | ||
|
||
#### # cite (optional) | ||
Expects a string for referencing the source for the quote. | ||
|
||
## Example 1: Yield a given block | ||
|
||
```ruby | ||
q id: "foo", class: "bar" do | ||
plain 'Hello World' # optional content | ||
end | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<q id="foo" class="bar"> | ||
Hello World | ||
</q> | ||
``` | ||
|
||
## Example 2: Render options[:text] param | ||
|
||
```ruby | ||
q id: "foo", class: "bar", cite: "helloworld.io" text: 'Hello World' | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<q id="foo" class="bar" cite="helloworld.io"> | ||
Hello World | ||
</q> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
require_relative "../../support/utils" | ||
include Utils | ||
|
||
describe "Q Component", type: :feature, js: true do | ||
|
||
it "Example 1" do | ||
|
||
class ExamplePage < Matestack::Ui::Page | ||
|
||
def response | ||
components { | ||
#simple q | ||
q text: "A simple quote" | ||
|
||
# enhanced q | ||
q id: 'my-id', class: 'my-class', cite: 'www.matestack.org/example' do | ||
plain 'This is a enhanced q with text' | ||
end | ||
} | ||
end | ||
|
||
end | ||
|
||
visit "/example" | ||
|
||
static_output = page.html | ||
|
||
expected_static_output = <<~HTML | ||
<q>A simple quote</q> | ||
<q cite="www.matestack.org/example" id="my-id" class="my-class">This is a enhanced q with text</q> | ||
HTML | ||
|
||
expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.