Skip to content

Add HTML <em> tag to core components #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

citizen428
Copy link
Contributor

@citizen428 citizen428 commented Oct 2, 2019

Closes #188

Issue #188: Add HTML <em> tag to core components

Changes

  • Adds HTML <em> tag core component + spec

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One trivial change and we're good to merge, @citizen428 - thank you for the help!

@@ -0,0 +1,40 @@
# matestack core component: Small
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't small ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, the one thing my search & replace missed because it wasn't case sensitive. 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I would've guessed!

@pascalwengerter pascalwengerter merged commit ab61ab8 into matestack:develop Oct 3, 2019
@jonasjabari jonasjabari added this to the 0.7.3 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants