Skip to content

Add HTML <em> tag to core components #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/concepts/matestack/ui/core/em/em.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
%em{@tag_attributes}
- if options[:text].nil? && block_given?
= yield
- else
= options[:text]
5 changes: 5 additions & 0 deletions app/concepts/matestack/ui/core/em/em.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module Matestack::Ui::Core::Em
class Em < Matestack::Ui::Core::Component::Static

end
end
40 changes: 40 additions & 0 deletions docs/components/em.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# matestack core component: Em

Show [specs](/spec/usage/components/em_spec.rb)

The HTML em tag implemented in Ruby.

## Parameters

This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param.

#### # id (optional)
Expects a string with all ids the em tag should have.

#### # class (optional)
Expects a string with all classes the em tag should have.

## Example 1: Yield a given block

```ruby
em id: "foo", class: "bar" do
plain 'Emphasized text' # optional content
end
```

returns

```html
<em id="foo" class="bar">Emphasized text</small>
```

## Example 2: Render options[:text] param

```ruby
em id: "foo", class: "bar", text: 'Emphasized text'
```

returns

```html
<em id="foo" class="bar">Emphasized text</small>
60 changes: 60 additions & 0 deletions spec/usage/components/em_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# frozen_string_literal: true

require_relative '../../support/utils'
include Utils

describe 'Em Component', type: :feature, js: true do
it 'Example 1 - yield, no options[:text]' do
class ExamplePage < Matestack::Ui::Page
def response
components do
# simple em tag
em do
plain 'Emphasized text'
end

# enhanced em tag
em id: 'my-id', class: 'my-class' do
plain 'Enhanced emphasized text'
end
end
end
end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<em>Emphasized text</em>
<em id="my-id" class="my-class">Enhanced emphasized text</em>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
end

it 'Example 2 - render options[:text]' do
class ExamplePage < Matestack::Ui::Page
def response
components do
# simple em
em text: 'Emphasized text'

# enhanced em
em id: 'my-id', class: 'my-class', text: 'Enhanced emphasized text'
end
end
end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<em>Emphasized text</em>
<em id="my-id" class="my-class">Enhanced emphasized text</em>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
end
end