-
-
Notifications
You must be signed in to change notification settings - Fork 43
ISSUE #176 Adds site tag to main components #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some typos and we're good to merge!
docs/components/cite.md
Outdated
|
||
Show [specs](/spec/usage/components/cite_spec.rb) | ||
|
||
The HTML span tag implemented in ruby. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ain't no span
;)
docs/components/cite.md
Outdated
This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param. | ||
|
||
#### # id (optional) | ||
Expects a string with all ids the span should have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
docs/components/cite.md
Outdated
Expects a string with all ids the span should have. | ||
|
||
#### # class (optional) | ||
Expects a string with all classes the span should have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, recommending search+replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Issue #176: cite tag
Changes
Notes