Skip to content

ISSUE #176 Adds site tag to main components #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

cameronnorman
Copy link
Collaborator

Issue #176: cite tag

Changes

  • Adds the site tag to the main components

Notes

  • Nothing special here

@cameronnorman cameronnorman changed the title Adds site tag to main components Issue #176 Adds site tag to main components Oct 4, 2019
@cameronnorman cameronnorman changed the title Issue #176 Adds site tag to main components ISSUE #176 Adds site tag to main components Oct 4, 2019
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some typos and we're good to merge!


Show [specs](/spec/usage/components/cite_spec.rb)

The HTML span tag implemented in ruby.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ain't no span ;)

This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param.

#### # id (optional)
Expects a string with all ids the span should have.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Expects a string with all ids the span should have.

#### # class (optional)
Expects a string with all classes the span should have.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, recommending search+replace

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pascalwengerter pascalwengerter merged commit 91e3353 into develop Oct 9, 2019
@pascalwengerter pascalwengerter deleted the issue-176 branch October 9, 2019 13:59
@jonasjabari jonasjabari added this to the 0.7.3 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants