Skip to content

ISSUE #176 Adds site tag to main components #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/concepts/matestack/ui/core/cite/cite.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
%cite{@tag_attributes}
- if options[:text].nil? && block_given?
= yield
- else
= options[:text]
5 changes: 5 additions & 0 deletions app/concepts/matestack/ui/core/cite/cite.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module Matestack::Ui::Core::Cite
class Cite < Matestack::Ui::Core::Component::Static

end
end
44 changes: 44 additions & 0 deletions docs/components/cite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
# matestack core component: Cite

Show [specs](/spec/usage/components/cite_spec.rb)

The HTML cite tag implemented in ruby.

## Parameters

This component can take 2 optional configuration params and either yield content or display what gets passed to the `text` configuration param.

#### # id (optional)
Expects a string with all ids the cite tag should have.

#### # class (optional)
Expects a string with all classes the cite tag should have.

## Example 1: Yield a given block

```ruby
cite id: "foo", class: "bar" do
plain 'Hello World' # optional content
end
```

returns

```html
<cite id="foo" class="bar">
Hello World
</cite>
```

## Example 2: Render options[:text] param

```ruby
cite id: "foo", class: "bar", text: 'Hello World'
```

returns

```html
<cite id="foo" class="bar">
Hello World
</cite>
66 changes: 66 additions & 0 deletions spec/usage/components/cite_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
require_relative "../../support/utils"
include Utils

describe 'Cite Component', type: :feature, js: true do

it 'Example 1 - yield, no options[:text]' do

class ExamplePage < Matestack::Ui::Page

def response
components {
# simple cite
cite do
plain 'I am simple'
end

# enhanced cite
cite id: 'my-id', class: 'my-class' do
plain 'I am enhanced'
end
}
end

end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<cite>I am simple</cite>
<cite id="my-id" class="my-class">I am enhanced</cite>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
end

it 'Example 2 - render options[:text]' do

class ExamplePage < Matestack::Ui::Page

def response
components {
# simple cite
cite text: 'I am simple'

# enhanced cite
cite id: 'my-id', class: 'my-class', text: 'I am enhanced'
}
end

end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<cite>I am simple</cite>
<cite id="my-id" class="my-class">I am enhanced</cite>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
end

end