Skip to content

add indentation & class_name to templates #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2019
Merged

add indentation & class_name to templates #249

merged 1 commit into from
Oct 19, 2019

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Oct 18, 2019 •
edited
Loading

While setting up a new project today, I found some room for improvement with the generators!

Changes

  • Added indentation to generated apps & pages
  • Changed naming for example partials & slots
  • Added app/page name in templates

@marcoroth marcoroth mentioned this pull request Oct 18, 2019
Merged
@pascalwengerter pascalwengerter merged commit 5cbf15b into develop Oct 19, 2019
@pascalwengerter pascalwengerter deleted the improve_generators branch October 19, 2019 17:29
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoroth marcoroth marcoroth approved these changes

@jonasjabari jonasjabari Awaiting requested review from jonasjabari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@pascalwengerter @marcoroth @jonasjabari