Refactor and improve generators #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change name: matestack_page => matestack:page - simplify the genration of a page - change structure of templates - add tests for the options --namespace and --controller_action
- change name: matestack_component => matestack:component - simplify the genration of a component - change structure of templates
- change name: matestack_app => matestack:app - simplify the generation of an app - change structure of templates
pascalwengerter
previously approved these changes
Oct 19, 2019
--namepsace --haml and --scss
pascalwengerter
approved these changes
Oct 27, 2019
pascalwengerter
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and improve generators
This Pull-Requests refactors the generators and changes the names of them.
Changes
update the generator names (It's more Rails-like this way)
rails g matestack_app=>rails g matestack:apprails g matestack_page=>rails g matestack:pagerails g matestack_component=>rails g matestack:componentsimplify the generation of a app/page/component
change the template handling
.ttsuffixtemplatesfolder the templates are now placed at the location where they will be generated in the app%variable%syntaxadd tests for the page generator for the options
--namespaceand--controller_actionupdate tooling docs
Notes
This PR is dependent on #249 and should only be merged after the other one is merged.