Skip to content

Refactor video component & fix tests #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2019
Merged

Refactor video component & fix tests #279

merged 2 commits into from
Nov 6, 2019

Conversation

pascalwengerter
Copy link
Contributor

Refactors video component

Changes

  • Replace Rails' = video_tag with plain HAML
  • Update and improve docs, add example
  • Refactor and improve specs

pascalwengerter added a commit that referenced this pull request Nov 6, 2019
@pascalwengerter
Merge pull request #278 from basemate/fixing_issue_277
231d04b 
Remove manifest link as it is not used and throws errors. Failing tests will be fixed via #279
@jonasjabari jonasjabari merged commit 5b2a975 into develop Nov 6, 2019
@pascalwengerter pascalwengerter deleted the improve_video_component branch November 6, 2019 15:44
@jonasjabari jonasjabari added this to the 0.7.3 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasjabari jonasjabari jonasjabari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalwengerter @jonasjabari