add picture matestack core component #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+29
to
+33
| <picture id="my-id" class="my-class"></picture> | ||
| HTML | ||
|
|
||
| expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
| expect(page).to have_xpath("//img[contains(@src,'matestack-logo')]") |
There was a problem hiding this comment.
Does this part work? It's defining and expecting an img-xpath but there's none in the static output?
There was a problem hiding this comment.
It should work. The expect on line 33 checks the tag defined on line 16-18.
I couldn't add the expected tag to the expected_static_output variable because the img component generates a different path for the logo on each run.
There was a problem hiding this comment.
Got it, thanks a lot for quick clarification mate!
pascalwengerter
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206
Issue #206: picture component
Add HTML
<picture>tag to core componentsChanges