Skip to content

add picture matestack core component #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/concepts/matestack/ui/core/picture/picture.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
%picture{@tag_attributes}
- if block_given?
= yield
4 changes: 4 additions & 0 deletions app/concepts/matestack/ui/core/picture/picture.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module Matestack::Ui::Core::Picture
class Picture < Matestack::Ui::Core::Component::Static
end
end
1 change: 1 addition & 0 deletions docs/components/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ You can build your [own components](/docs/extend/README.md) as well, both static
- [paragraph](/docs/components/paragraph.md)
- [param](/docs/components/param.md)
- [pg](/docs/components/pg.md)
- [picture](/docs/components/picture.md)
- [plain](/docs/components/plain.md)
- [pre](/docs/components/pre.md)
- [progress](/docs/components/progress.md)
Expand Down
31 changes: 31 additions & 0 deletions docs/components/picture.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# matestack core component: Picture

Show [specs](/spec/usage/components/picture_spec.rb)

The HTML `<picture>` tag implemented in ruby.

## Parameters

This component can take 2 optional configuration params and yield the passed content.

#### # id (optional)
Expects a string with all ids the `<picture>` should have.

#### # class (optional)
Expects a string with all classes the `<picture>` should have.

## Example: Yield a given block

```ruby
picture id: 'foo', class: 'bar' do
img path: 'matestack-logo.png'
end
```

returns

```html
<picture id="foo" class="bar">
<img src="/assets/matestack-logo-XXXX.png" />
</picture>
```
35 changes: 35 additions & 0 deletions spec/usage/components/picture_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
require_relative '../../support/utils'
include Utils

describe 'Picture component', type: :feature, js: true do
it 'Renders a picture tag on a page' do
class ExamplePage < Matestack::Ui::Page
def response
components {
# Just the tag
picture

# With attributes
picture id: 'my-id', class: 'my-class'

# With a sub-component
picture do
img path: 'matestack-logo.png'
end
}
end
end

visit '/example'

static_output = page.html

expected_static_output = <<~HTML
<picture></picture>
<picture id="my-id" class="my-class"></picture>
HTML

expect(stripped(static_output)).to include(stripped(expected_static_output))
expect(page).to have_xpath("//img[contains(@src,'matestack-logo')]")
Comment on lines +29 to +33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this part work? It's defining and expecting an img-xpath but there's none in the static output?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work. The expect on line 33 checks the tag defined on line 16-18.
I couldn't add the expected tag to the expected_static_output variable because the img component generates a different path for the logo on each run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks a lot for quick clarification mate!

end
end