-
-
Notifications
You must be signed in to change notification settings - Fork 43
add picture matestack core component #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
%picture{@tag_attributes} | ||
- if block_given? | ||
= yield |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module Matestack::Ui::Core::Picture | ||
class Picture < Matestack::Ui::Core::Component::Static | ||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# matestack core component: Picture | ||
|
||
Show [specs](/spec/usage/components/picture_spec.rb) | ||
|
||
The HTML `<picture>` tag implemented in ruby. | ||
|
||
## Parameters | ||
|
||
This component can take 2 optional configuration params and yield the passed content. | ||
|
||
#### # id (optional) | ||
Expects a string with all ids the `<picture>` should have. | ||
|
||
#### # class (optional) | ||
Expects a string with all classes the `<picture>` should have. | ||
|
||
## Example: Yield a given block | ||
|
||
```ruby | ||
picture id: 'foo', class: 'bar' do | ||
img path: 'matestack-logo.png' | ||
end | ||
``` | ||
|
||
returns | ||
|
||
```html | ||
<picture id="foo" class="bar"> | ||
<img src="/assets/matestack-logo-XXXX.png" /> | ||
</picture> | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
require_relative '../../support/utils' | ||
include Utils | ||
|
||
describe 'Picture component', type: :feature, js: true do | ||
it 'Renders a picture tag on a page' do | ||
class ExamplePage < Matestack::Ui::Page | ||
def response | ||
components { | ||
# Just the tag | ||
picture | ||
|
||
# With attributes | ||
picture id: 'my-id', class: 'my-class' | ||
|
||
# With a sub-component | ||
picture do | ||
img path: 'matestack-logo.png' | ||
end | ||
} | ||
end | ||
end | ||
|
||
visit '/example' | ||
|
||
static_output = page.html | ||
|
||
expected_static_output = <<~HTML | ||
<picture></picture> | ||
<picture id="my-id" class="my-class"></picture> | ||
HTML | ||
|
||
expect(stripped(static_output)).to include(stripped(expected_static_output)) | ||
expect(page).to have_xpath("//img[contains(@src,'matestack-logo')]") | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this part work? It's defining and expecting an
img
-xpath but there's none in the static output?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work. The
expect
on line 33 checks the tag defined on line 16-18.I couldn't add the expected tag to the
expected_static_output
variable because the img component generates a different path for the logo on each run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks a lot for quick clarification mate!