Skip to content

add option matestack core component #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

add option matestack core component #306

merged 1 commit into from
Dec 4, 2019

Conversation

marcoroth
Copy link
Collaborator

Closes #203

Issue #203: option component

Add HTML <option> tag to core components

Changes

  • Add option component
  • Add specs
  • Add docs

@marcoroth marcoroth marked this pull request as ready for review November 23, 2019 17:52
@marcoroth marcoroth mentioned this pull request Nov 23, 2019
Merged
3 tasks
pascalwengerter
pascalwengerter approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work!

@pascalwengerter pascalwengerter merged commit 1bb4424 into matestack:develop Dec 4, 2019
@pascalwengerter pascalwengerter mentioned this pull request Dec 4, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@borref borref Awaiting requested review from borref

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoroth @pascalwengerter @jonasjabari