Skip to content

add optgroup matestack core component #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2019
Merged

add optgroup matestack core component #307

merged 2 commits into from
Dec 4, 2019

Conversation

marcoroth
Copy link
Collaborator

Closes #202

Issue #202: optgroup component

Add HTML <optgroup> tag to core components

Changes

  • Add optgroup component
  • Add specs
  • Add docs

Notes

This PR is dependent on #306 and should only be merged afterwards.

@marcoroth marcoroth marked this pull request as ready for review November 23, 2019 18:16
pascalwengerter
pascalwengerter approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' well!

@pascalwengerter pascalwengerter merged commit 9721614 into matestack:develop Dec 4, 2019
@pascalwengerter pascalwengerter mentioned this pull request Dec 4, 2019
Closed
@jonasjabari jonasjabari added this to the 0.7.4 milestone Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@borref borref Awaiting requested review from borref

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.4
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoroth @pascalwengerter @jonasjabari