Merge #343

343: Remove guaranteed compatibility with versions to 10> and <15  r=bidoubiwa a=bidoubiwa

fixes: #346

Since the builded package can be used (without guarantee) in other node versions, we should not make it mandatory to use the right node version. It is at the discretion of the user. 

It is how most libraries handle node support. The use of `engines` in packages json limits the possibility to install the package in a specific node environment (see [issue](meilisearch/documentation#963 (comment))).
Whereas typically a package that is bundled and transpiled should be as compatible as possible with all js environments. But, the packages we use in development are not. This is why we add it in the CONTRIBUTING guide


Co-authored-by: Charlotte Vermandel <[email protected]>

Author: bors[bot]

.github/workflows/tests.yml

@@ -11,25 +11,24 @@ on:
 
 jobs:
   tests:
-    name: tests
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node: [ '12', '14' ]
+    name: Tests (Node.js ${{ matrix.node }})
     steps:
-    - uses: actions/checkout@v2
-    - name: Read .nvmrc
-      run: echo "##[set-output name=NVMRC;]$(cat .nvmrc)"
-      id: nvm
-    - name: Use Node.js (.nvmrc)
-      uses: actions/setup-node@v1
-      with:
-        node-version: "${{ steps.nvm.outputs.NVMRC }}"
-    - name: Display node version (from .nvmrc)
-      run: echo "Using ${{ steps.nvm.outputs.NVMRC }}"
-    - name: Install dependencies
-      run: yarn install
-    - name: Build
-      run: yarn run build
-    - name: Run tests
-      run: yarn run test
+      - uses: actions/checkout@v2
+      - name: Setup node
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node }}
+      - name: Install dependencies
+        run: yarn install
+      - name: Build
+        run: yarn run build
+      - name: Run tests
+        run: yarn run test
 
   linter:
     name: linter-check

.nvmrc

@@ -30,7 +30,7 @@ First of all, thank you for contributing to MeiliSearch! The goal of this docume
 
 To run this project, you will need:
 
-- Node.js >= v8.7.0, use nvm - [installation instructions](https://github.com/creationix/nvm#install-script)
+- Node.js >= v12 and node < 15
 - Yarn
 
 ### Install <!-- omit in TOC -->

CONTRIBUTING.md

@@ -1,3 +1,7 @@
-status = ['tests', 'linter-check']
+status = [
+    'linter-check',
+    'Tests (Node.js 12)',
+    'Tests (Node.js 14)'
+]
 # 1 hour timeout
 timeout-sec = 3600