Remove guaranteed compatibility with versions to 10> and <15 #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
force-pushed
the
remove_node_10_support
branch
from
61dd0ff to
12472f8
Compare
bidoubiwa
changed the title
bidoubiwa
changed the title
bidoubiwa
changed the title
mdubus
previously approved these changes
Jun 7, 2021
curquiza
requested changes
Jun 7, 2021
|
|
bidoubiwa
force-pushed
the
upgrade_playground
branch
from
bc42e9e to
481537b
Compare
Remove node 16 tests Stop compatibility at under node 15 Don't make it impossible to use the build of the package unsuported node versions Apply suggestions from code review Co-authored-by: Clémentine Urquizar <[email protected]>
bidoubiwa
force-pushed
the
remove_node_10_support
branch
from
0136b8a to
88fce3a
Compare
curquiza
approved these changes
Jun 7, 2021
|
bors merge |
|
Build succeeded: |
bidoubiwa
added
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #346
Since the builded package can be used (without guarantee) in other node versions, we should not make it mandatory to use the right node version. It is at the discretion of the user.
It is how most libraries handle node support. The use of
enginesin packages json limits the possibility to install the package in a specific node environment (see issue).Whereas typically a package that is bundled and transpiled should be as compatible as possible with all js environments. But, the packages we use in development are not. This is why we add it in the CONTRIBUTING guide