-
Notifications
You must be signed in to change notification settings - Fork 90
New ndjson handlers #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ndjson handlers #560
Conversation
Hello @Azanul, PS: This message was sent automatically! |
bors try |
tryBuild failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Azanul for this PR!
I add some comments 😃
Review changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Azanul thanks for the changes, there are still some errors running on the tests I recommend you to check the put
method 😃
Co-authored-by: Amélie <[email protected]>
Co-authored-by: Amélie <[email protected]>
`str` type allowed in `put` request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @Azanul for this PR 🎉
LGTM!
bors merge |
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
Pull Request
Related issue
Fixes #347
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!