Skip to content

New ndjson handlers #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2022
Merged

New ndjson handlers #560

merged 6 commits into from
Oct 17, 2022

Conversation

Azanul
Copy link
Contributor

@Azanul Azanul commented Oct 14, 2022

Pull Request

Related issue

Fixes #347

What does this PR do?

  • Adds handler for updating documents with raw string
  • Adds handler for updating documents with ndjson string.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@alallema
Copy link
Contributor

Hello @Azanul,
Thank you very much for contributing to Meilisearch ❤️.
However, I am not available on the weekend, but I will be back on Monday 😊.

PS: This message was sent automatically!

@alallema
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Oct 17, 2022
@bors
Copy link
Contributor

bors bot commented Oct 17, 2022

try

Build failed:

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Azanul for this PR!
I add some comments 😃

Review changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Azanul thanks for the changes, there are still some errors running on the tests I recommend you to check the put method 😃

Azanul and others added 3 commits October 17, 2022 16:45
`str` type allowed in `put` request
@Ambareen09 Ambareen09 mentioned this pull request Oct 17, 2022
3 tasks
@Azanul Azanul requested a review from alallema October 17, 2022 11:48
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Azanul for this PR 🎉
LGTM!

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 17, 2022

@bors bors bot merged commit 4ebee15 into meilisearch:main Oct 17, 2022
@alallema
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@alallema alallema added hacktoberfest enhancement New feature or request labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NDJSON/CSV methods to add and update documents
2 participants