Implement faceting in search #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
force-pushed
the
facets-in-search
branch
2 times, most recently
from
9f277a0 to
0af4f23
Compare
eskombro
requested changes
Jun 4, 2020
curquiza
force-pushed
the
facets-in-search
branch
from
0af4f23 to
1c5fd80
Compare
bidoubiwa
reviewed
Jun 8, 2020
curquiza
force-pushed
the
facets-in-search
branch
from
8d7ce4c to
74b94d2
Compare
curquiza
added a commit
that referenced
this pull request
Jun 9, 2020
* Implement faceting in search * Upd test
curquiza
added a commit
that referenced
this pull request
Jun 15, 2020
* Upd version * Add method to use faceting sub routes (#90) * Remane apikey into api_key (#93) * Implement faceting in search (#94) * Implement faceting in search * Upd test * Clear all indexes before starting tests in a certain context (#95) * Clear all indexes before starting tests in a certain context * Update meilisearch/tests/__init__.py Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> * Upd version * Add method to use faceting sub routes (#90) * Remane apikey into api_key (#93) * Implement faceting in search (#94) * Implement faceting in search * Upd test * Fix parameter default value (#97) * Add test with multiple facetFilters (#98) * Change create_index prototype (#99) * Change create_index prototype * Update meilisearch/client.py Co-authored-by: cvermand <[email protected]> * Update meilisearch/index.py Co-authored-by: cvermand <[email protected]> Co-authored-by: cvermand <[email protected]> Co-authored-by: Samuel Jimenez <[email protected]> Co-authored-by: cvermand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About pylint rule:I disable the
dangerous-default-valueinsearchmethod because I think this is useless to refuse parameter default value asopt_params={}and then write as the first line of code in the method:What do you think?Found out it's a really bad practice, it does not work as expected.