Add support to the pagination setting customization at the index level

[vishalsodani]

Pull Request

What does this PR do?

Fixes #304

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[bidoubiwa]

Hello @vishalsodani,
Thank you very much for contributing to Meilisearch ❤️.
However, I am not available on the weekend, but I will be back on Monday 😊.

PS: This message was sent automatically!

[bidoubiwa]

Thanks a lot for your contribution 🔥

[bidoubiwa]

Please go over your code again to ensure that you updated the types everywhere.

[vishalsodani]

Please go over your code again to ensure that you updated the types everywhere.

Thanks! Sure.

[vishalsodani]

Please go over your code again to ensure that you updated the types everywhere.

Should I add PaginationSetting to Settings struct as a member?

[bidoubiwa]

Absolutely!

[bidoubiwa]

Could you add tests at the bottom of the file? I do realize that there are no previous tests made, but we should start making them

[vishalsodani]

Could you add tests at the bottom of the file? I do realize that there are no previous tests made, but we should start making them

What tests? Are you asking to write some specific kind of tests?

[bidoubiwa]

At the bottom of the settings.rs you can start adding tests the following way:

#[cfg(test)]
mod tests {
    use super::*;

    use crate::client::*;
    use meilisearch_test_macro::meilisearch_test;

    #[meilisearch_test]
    async fn test_get_pagination(index: Index) {
        let res = index.get_pagination().await.unwrap();
        let pagination = PaginationSetting {
            max_total_hits: 1000,
        };

        assert_eq!(pagination, res);
    }
}

Could you also make one for update and reset?

[bidoubiwa]

Some styling changes

[vishalsodani]

At the bottom of the settings.rs you can start adding tests the following way:

#[cfg(test)]
mod tests {
    use super::*;

    use crate::client::*;
    use meilisearch_test_macro::meilisearch_test;

    #[meilisearch_test]
    async fn test_get_pagination(index: Index) {
        let res = index.get_pagination().await.unwrap();
        let pagination = PaginationSetting {
            max_total_hits: 1000,
        };

        assert_eq!(pagination, res);
    }
}

Could you also make one for update and reset?

Done.

[bidoubiwa]

Are you still working on this @vishalsodani?

[vishalsodani]

Are you still working on this @vishalsodani?

Yes, of course. Are there any issues left to be fixed?

[bidoubiwa]

Yes unfortunately there is a conflict, could you resolve it?

[vishalsodani]

Yes unfortunately there is a conflict, could you resolve it?

resolved.

[bidoubiwa]

Your clippy checks are failing, could you resolve them?

[vishalsodani]

Your clippy checks are failing, could you resolve them?

Any idea about this issue?

https://github.com/meilisearch/meilisearch-rust/actions/runs/3198029601/jobs/5222032915#step:4:184

error: large size difference between variants

[bidoubiwa]

@irevoire any idea about this? Is boxing the good response to this issue?

[bidoubiwa]

I checked with him and it's good :) It should even improve the performances

[bidoubiwa]

LGTM 🔥🔥🔥🔥🔥

[bidoubiwa]

bors merge

[bors]

Build succeeded:

• clippy-check
• integration-tests
• readme-check
• rust-format
• wasm-build

[bidoubiwa]

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.