Skip to content

Add faceting index settings methods #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2022
Merged

Add faceting index settings methods #344

merged 2 commits into from
Oct 5, 2022

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented Oct 3, 2022

Pull Request

Related issue

Fixes #305

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

bidoubiwa
bidoubiwa suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests at the bottom of the file?
I see that their are no previous tests made but new ones should be added.

@bidoubiwa bidoubiwa requested a review from irevoire October 4, 2022 15:25
@bidoubiwa
Copy link
Contributor

For the tests, you can see what I commented on the other PR #342 (review)

@Ugzuzg Ugzuzg force-pushed the feat/faceting branch 4 times, most recently from eacc436 to 8e95cca Compare October 4, 2022 18:11
@Ugzuzg Ugzuzg requested review from bidoubiwa and removed request for irevoire October 4, 2022 18:12
bidoubiwa
bidoubiwa suggested changes Oct 5, 2022
View reviewed changes
@Ugzuzg Ugzuzg requested a review from bidoubiwa October 5, 2022 11:36
bidoubiwa
bidoubiwa reviewed Oct 5, 2022
View reviewed changes
@Ugzuzg Ugzuzg requested a review from bidoubiwa October 5, 2022 11:37
bidoubiwa
bidoubiwa approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bidoubiwa bidoubiwa added the enhancement New feature or request label Oct 5, 2022
@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 5, 2022

Build succeeded:

@bors bors bot merged commit 655f360 into meilisearch:main Oct 5, 2022
@bidoubiwa
Copy link
Contributor

Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.

@Ugzuzg Ugzuzg deleted the feat/faceting branch October 5, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the facet setting customization at the index level
2 participants
@Ugzuzg @bidoubiwa