-
Notifications
You must be signed in to change notification settings - Fork 100
Add cancel task for v0.30.0 #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bidoubiwa
merged 34 commits into
bump-meilisearch-v0.30.0
from
bump-meilisearch-v0.30.0-add-cancel-task
Nov 17, 2022
Merged
Add cancel task for v0.30.0 #377
bidoubiwa
merged 34 commits into
bump-meilisearch-v0.30.0
from
bump-meilisearch-v0.30.0-add-cancel-task
Nov 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilisearch/meilisearch-rust into bump-meilisearch-v0.30.0-add-cancel-task
Base automatically changed from
add_tasks_filters_for_v0.30.0
to
bump-meilisearch-v0.30.0
November 15, 2022 18:10
alallema
reviewed
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. Also the tests seems to be broken
alallema
reviewed
Nov 17, 2022
* Add delete tasks for v0.30.0 * Add swap indexes for v0.30.0 (#382) * Add swap indexes for v0.30.0 * Implement swap indexes * Add indexSwap detail * Use tuples as type for the indexes field * Add tests on index swap * Create better documentation for indexes swap * Fix clippy errors * Fix missing bracket * Fix swap doc test * Make doc more clear
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
399: Update version for the next release (v0.21.0) r=bidoubiwa a=bidoubiwa This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - New `pagination` strategy with the search parameters`page` and `hitsPerPage` #374 - New bulder methods on `get_tasks`: `with_uids`, `with_before_enqueued_at`, ... see #375 - New `client.cancel_tasks` method that lets you cancel `enqueued` and `processing` tasks #377 - New `client.delete_tasks` method that lets you delete tasks #381 - New `client.swap_indexes` method that lets you swap two indexes #382 ##⚠️ Breaking change - builder functions on `TasksQuery` name changes: #375 - `with_status` -> `with_statuses` - `with_index_uid` -> `with_index_uids` - `with_type` -> `with_types` - Task detail `receivedDocumentIds` renamed to `providedIds` #393 - Error field in `Task` is now always present and has a `None` value when there are no errors #390 - Add and rename some error codes: #384 Co-authored-by: Charlotte Vermandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
TasksQuery
structure toTasksSearchQuery
when building the query parameters for aget_tasks
call.before:
after:
TasksSearchQuery
are now private. Meaning you cannot do this anymore:Enhancement
tasksCancelQuery
to structure to build the filters to cancel tasks.Todo
Implementation
TasksQuery
toTasksSearchQuery
TasksCancelQuery
TasksQuery
:TasksQuery
filters private.with_from
only available onTasksSearchQuery
with_limit
only available onTasksSearchQuery
canceledBy
in the task returnTests:
TasksCancelQuery