-
Notifications
You must be signed in to change notification settings - Fork 100
Add swap indexes for v0.30.0 #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bidoubiwa
merged 11 commits into
bump-meilisearch-v0.30.0-add-delete-tasks
from
bump-meilisearch-v0.30.0-add-swap-indexes-v0.30.0
Nov 17, 2022
Merged
Add swap indexes for v0.30.0 #382
bidoubiwa
merged 11 commits into
bump-meilisearch-v0.30.0-add-delete-tasks
from
bump-meilisearch-v0.30.0-add-swap-indexes-v0.30.0
Nov 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilisearch-v0.30.0-add-swap-indexes-v0.30.0
alallema
reviewed
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few question but well done 🔥 🔥 🔥
b140892
to
bd9e602
Compare
alallema
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 🍣
bidoubiwa
added a commit
that referenced
this pull request
Nov 17, 2022
* Add delete tasks for v0.30.0 * Add swap indexes for v0.30.0 (#382) * Add swap indexes for v0.30.0 * Implement swap indexes * Add indexSwap detail * Use tuples as type for the indexes field * Add tests on index swap * Create better documentation for indexes swap * Fix clippy errors * Fix missing bracket * Fix swap doc test * Make doc more clear
bidoubiwa
added a commit
that referenced
this pull request
Nov 17, 2022
* Update README.md * Update README.tpl * Add filters in tasksQuery * Add new error codes * Add builder methods and tests * Fix clippy suggestions * Update src/tasks.rs Co-authored-by: Amélie <[email protected]> * Implement default taskQuery structure * Fix flacky tests * Fix get_tasks test * Refactor filtering of tasks * Rename index_uids and task types * Rename uid, status and types filters to plural * Add new error codes * Update error code to plural form * Update code samples * Update code-samples with new filter plural naming * Rename filters to plural form * Implement cancel_tasks * Add taskCancelation task details * Fix execution of get_tasks * Add canceled by as a return from task * Fix taskCancelation detail * Fix typing error * Chage type of canceled_by * Make variable plural * Rollback unrelated changes * Change variable to plural form * Add delete tasks for v0.30.0 (#381) * Add delete tasks for v0.30.0 * Add swap indexes for v0.30.0 (#382) * Add swap indexes for v0.30.0 * Implement swap indexes * Add indexSwap detail * Use tuples as type for the indexes field * Add tests on index swap * Create better documentation for indexes swap * Fix clippy errors * Fix missing bracket * Fix swap doc test * Make doc more clear Co-authored-by: meili-bot <[email protected]> Co-authored-by: Amélie <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
399: Update version for the next release (v0.21.0) r=bidoubiwa a=bidoubiwa This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - New `pagination` strategy with the search parameters`page` and `hitsPerPage` #374 - New bulder methods on `get_tasks`: `with_uids`, `with_before_enqueued_at`, ... see #375 - New `client.cancel_tasks` method that lets you cancel `enqueued` and `processing` tasks #377 - New `client.delete_tasks` method that lets you delete tasks #381 - New `client.swap_indexes` method that lets you swap two indexes #382 ##⚠️ Breaking change - builder functions on `TasksQuery` name changes: #375 - `with_status` -> `with_statuses` - `with_index_uid` -> `with_index_uids` - `with_type` -> `with_types` - Task detail `receivedDocumentIds` renamed to `providedIds` #393 - Error field in `Task` is now always present and has a `None` value when there are no errors #390 - Add and rename some error codes: #384 Co-authored-by: Charlotte Vermandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the specification
Enhancement
It is now possible to swap two indexes
Usage:
Complete Example:
todo
SwapIndexes
structswap_indexes
on client