Changes related to the next Meilisearch release (v0.26.0) #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bot
added
the
skip-changelog
curquiza
force-pushed
the
bump-meilisearch-v0.26.0
branch
from
289e452 to
fd7a4a1
Compare
curquiza
force-pushed
the
bump-meilisearch-v0.26.0
branch
from
fd7a4a1 to
0d9f4da
Compare
* Update .github/workflows/tests.yml * Update .github/workflows/pre-release-tests.yml * Remove --no-analytics=true from docker-compose.yml Co-authored-by: Bruno Casali <[email protected]>
#172) * Update meilisearch/meilisearch-php requirement from ^0.21.0 to ^0.23.0 Updates the requirements on meilisearch/meilisearch-php to permit the latest version. --- updated-dependencies: - dependency-name: meilisearch/meilisearch-php dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Remove `testGetDefaultSettings` since this test should be in the meilisearch-php Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bruno Casali <[email protected]>
brunoocasali
approved these changes
Mar 16, 2022
| @@ -40,41 +40,6 @@ public function setUp(): void | |||
| $this->application = new Application(self::$kernel); | |||
| } | |||
|
|
|||
| public function testGetDefaultSettings(): void | |||
There was a problem hiding this comment.
I really think we should not be testing the meilisearch-php in a client (in this case Symfony lib). This test belongs to the meilisearch-php :)
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gathers the changes related to the next Meilisearch release (v0.26.0) so that this package is ready when the official release is out.
meilisearch-phpdependency has been released to be compatible with Meilisearch v0.26.0.Once the release is out, the upgrade of the
meilisearch-phpdependency might be committed to this branch.This PR is auto-generated for the pre-release week purpose.
Related to this issue: meilisearch/integration-guides#181