Skip to content

Changes related to the next Meilisearch release (v0.26.0) #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2022
Merged

Changes related to the next Meilisearch release (v0.26.0) #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a38694e
Update README.md
meili-bot Feb 10, 2022
0d9f4da
Rename test file (#169)
curquiza Feb 15, 2022
64f4d54
Replace --no-analytics=true with --no-analytics (#170)
meili-bot Feb 16, 2022
fd8dae3
Update meilisearch/meilisearch-php requirement from ^0.21.0 to ^0.23.…
dependabot[bot] Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pre-release-test.yaml → .github/workflows/pre-release-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ jobs:
- name: Get the latest Meilisearch RC
run: echo "MEILISEARCH_VERSION=$(curl https://raw.githubusercontent.com/meilisearch/integration-guides/main/scripts/get-latest-meilisearch-rc.sh | bash)" >> $GITHUB_ENV
- name: Meilisearch (${{ env.MEILISEARCH_VERSION }}) setup with Docker
run: docker run -d -p 7700:7700 getmeili/meilisearch:${{ env.MEILISEARCH_VERSION }} ./meilisearch --master-key=masterKey --no-analytics=true
run: docker run -d -p 7700:7700 getmeili/meilisearch:${{ env.MEILISEARCH_VERSION }} ./meilisearch --master-key=masterKey --no-analytics
- name: Run test suite
run: composer test:unit
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
SYMFONY_REQUIRE: ${{ matrix.sf-version }}
run: composer install --prefer-dist --no-progress --quiet
- name: Meilisearch setup with Docker
run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics=true
run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --master-key=masterKey --no-analytics
- name: Run test suite
run: composer test:unit

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Also, see our [Documentation](https://docs.meilisearch.com/learn/tutorials/getti

## 🤖 Compatibility with Meilisearch

This package only guarantees the compatibility with the [version v0.25.0 of Meilisearch](https://github.com/meilisearch/meilisearch/releases/tag/v0.25.0).
This package only guarantees the compatibility with the [version v0.26.0 of Meilisearch](https://github.com/meilisearch/meilisearch/releases/tag/v0.26.0).

## 💡 Learn More

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"ext-json": "*",
"doctrine/doctrine-bundle": "^2.4",
"illuminate/collections": "^8.47",
"meilisearch/meilisearch-php": "^0.21.0",
"meilisearch/meilisearch-php": "^0.23.0",
"symfony/filesystem": "^4.4 || ^5.0 || ^6.0",
"symfony/property-access": "^4.4 || ^5.0 || ^6.0",
"symfony/serializer": "^4.4 || ^5.0 || ^6.0"
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ services:

meilisearch:
image: getmeili/meilisearch
command: ./meilisearch --master-key=masterKey --no-analytics=true
command: ./meilisearch --master-key=masterKey --no-analytics
ports:
- target: 7700
published: 7700
Expand Down
35 changes: 0 additions & 35 deletions tests/Integration/SettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,41 +40,6 @@ public function setUp(): void
$this->application = new Application(self::$kernel);
}

public function testGetDefaultSettings(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think we should not be testing the meilisearch-php in a client (in this case Symfony lib). This test belongs to the meilisearch-php :)

{
$primaryKey = 'ObjectID';
$indexAName = $this->getPrefix().'indexA';
$indexBName = $this->getPrefix().'indexB';
$this->client->createIndex($indexAName);
$this->client->createIndex($indexBName, ['primaryKey' => $primaryKey]);

$firstTask = $this->client->getTasks()['results'][0];
$this->client->waitForTask($firstTask['uid']);

$settingA = $this->client->index($indexAName)->getSettings();
$settingB = $this->client->index($indexBName)->getSettings();

$this->assertEquals(self::DEFAULT_RANKING_RULES, $settingA['rankingRules']);
$this->assertNull($settingA['distinctAttribute']);
$this->assertIsArray($settingA['searchableAttributes']);
$this->assertEquals(['*'], $settingA['searchableAttributes']);
$this->assertIsArray($settingA['displayedAttributes']);
$this->assertEquals(['*'], $settingA['displayedAttributes']);
$this->assertIsArray($settingA['stopWords']);
$this->assertEmpty($settingA['stopWords']);
$this->assertIsArray($settingA['synonyms']);
$this->assertEmpty($settingA['synonyms']);

$this->assertEquals(self::DEFAULT_RANKING_RULES, $settingB['rankingRules']);
$this->assertNull($settingB['distinctAttribute']);
$this->assertEquals(['*'], $settingB['searchableAttributes']);
$this->assertEquals(['*'], $settingB['displayedAttributes']);
$this->assertIsArray($settingB['stopWords']);
$this->assertEmpty($settingB['stopWords']);
$this->assertIsArray($settingB['synonyms']);
$this->assertEmpty($settingB['synonyms']);
}

public function testUpdateSettings(): void
{
$index = $this->getPrefix().self::$indexName;
Expand Down