Skip to content

Allow to configure custom serializer groups #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2023
Merged

Allow to configure custom serializer groups #239

merged 1 commit into from
May 16, 2023

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Apr 4, 2023

Pull Request

Related issue

Fixes #238

What does this PR do?

  • Allows to configure custom serializer groups instead of the default one Meilisearch\Bundle\Searchable::NORMALIZATION_GROUP.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@bidoubiwa
Copy link
Contributor

Hey @norkunas! Thanks a lot for your contribution 🔥

The maintainer of this repo @brunoocasali is currently on holiday. He'll be back next week to review you!

norkunas
norkunas commented Apr 5, 2023
View reviewed changes
@brunoocasali
Copy link
Member

Hi, @norkunas. I will need more time to review this PR. Sorry about that!

@brunoocasali brunoocasali added the enhancement New feature or request label Apr 13, 2023
brunoocasali
brunoocasali reviewed May 12, 2023
View reviewed changes
brunoocasali
brunoocasali requested changes May 12, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @norkunas very sorry for taking too much time to answer you.

So, I tried to make some changes locally and the tests did not break, can you help me understand more about the change you are proposing?

Thank you!

@norkunas
Copy link
Collaborator Author

Hi @norkunas very sorry for taking too much time to answer you.

So, I tried to make some changes locally and the tests did not break, can you help me understand more about the change you are proposing?

Thank you!

Will check it on monday. See the issue to understand about it :)

@norkunas norkunas force-pushed the custom-serializer-groups branch 3 times, most recently from 7e88ada to 261197c Compare May 16, 2023 06:58
norkunas
norkunas commented May 16, 2023
View reviewed changes
norkunas
norkunas commented May 16, 2023
View reviewed changes
norkunas
norkunas commented May 16, 2023
View reviewed changes
@norkunas norkunas force-pushed the custom-serializer-groups branch from 261197c to 1bd32ab Compare May 16, 2023 07:10
norkunas
norkunas commented May 16, 2023
View reviewed changes
norkunas
norkunas commented May 16, 2023
View reviewed changes
norkunas
norkunas commented May 16, 2023
View reviewed changes
@norkunas norkunas force-pushed the custom-serializer-groups branch 3 times, most recently from 5489058 to 7a3cd55 Compare May 16, 2023 07:38
@norkunas norkunas force-pushed the custom-serializer-groups branch from 7a3cd55 to ea10878 Compare May 16, 2023 07:40
@norkunas
Copy link
Collaborator Author

Okay so now there are many unrelated changes, if you'll want I could move them to another PR

@brunoocasali
Copy link
Member

Okay so now there are many unrelated changes, if you'll want I could move them to another PR

not needed @norkunas!

brunoocasali
brunoocasali approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @norkunas 🎉

bors merge

brunoocasali
brunoocasali approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @norkunas 🎉

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 16, 2023

Already running a review

@brunoocasali brunoocasali merged commit ee45313 into meilisearch:main May 16, 2023
@brunoocasali brunoocasali added the breaking-change The related changes are breaking for the users label May 16, 2023
@brunoocasali brunoocasali mentioned this pull request May 16, 2023
Merged
@norkunas norkunas deleted the custom-serializer-groups branch May 17, 2023 03:36
meili-bors bot added a commit that referenced this pull request May 17, 2023
@meili-bors @meili-bot
Merge #252
e4411ca 
252: Update version for the next release (v0.12.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-symfony to a new version: "v0.12.0"


**RELEASE CHANGELOG:**

## 💥 Breaking Changes

* Accept a `normalizationGroups` as an array instead of the boolean `useSerializerGroup` when using `SearchableEntity` directly (#239) `@norkunas`
* Allow configuring in `config/meilisearch.yml` a custom serializer groups instead of the default one (#239) `@norkunas`

Example:
```yml
enable_serializer_groups: true
serializer_groups: ['public', 'private']
```

## 🚀 Enhancements

* Start fixing PHPMD issues (#250) `@brunoocasali`

## 💅 Misc

* Add phpmd to project (#165) `@jonatanrdsantos`

Thanks again to `@brunoocasali,` `@curquiza,` `@jonatanrdsantos,` `@norkunas!` 🎉



Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configurable serialization group(s)
3 participants
@norkunas @bidoubiwa @brunoocasali