Start fixing PHPMD issues #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
reviewed
May 15, 2023
| @@ -110,7 +110,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int | |||
| $repository = $manager->getRepository($entityClassName); | |||
| $classMetadata = $manager->getClassMetadata($entityClassName); | |||
| $entityIdentifiers = $classMetadata->getIdentifierFieldNames(); | |||
| $sortByIdentifiersParam = array_combine($entityIdentifiers, array_fill(0, count($entityIdentifiers), 'ASC')); | |||
| $sortByAttrsParam = array_combine($entityIdentifiers, array_fill(0, count($entityIdentifiers), 'ASC')); | |||
There was a problem hiding this comment.
What does an object look like? is sortByAttrs not enough?
brunoocasali
commented
May 15, 2023
Co-authored-by: cvermand <[email protected]>
brunoocasali
force-pushed
the
start-fixing-phpmd-issues
branch
from
1e8ecbd to
4061979
Compare
|
bors merge |
|
Build succeeded:
|
meili-bors bot
added a commit
that referenced
this pull request
May 17, 2023
252: Update version for the next release (v0.12.0) r=brunoocasali a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-symfony to a new version: "v0.12.0" **RELEASE CHANGELOG:** ## 💥 Breaking Changes * Accept a `normalizationGroups` as an array instead of the boolean `useSerializerGroup` when using `SearchableEntity` directly (#239) `@norkunas` * Allow configuring in `config/meilisearch.yml` a custom serializer groups instead of the default one (#239) `@norkunas` Example: ```yml enable_serializer_groups: true serializer_groups: ['public', 'private'] ``` ## 🚀 Enhancements * Start fixing PHPMD issues (#250) `@brunoocasali` ## 💅 Misc * Add phpmd to project (#165) `@jonatanrdsantos` Thanks again to `@brunoocasali,` `@curquiza,` `@jonatanrdsantos,` `@norkunas!` 🎉 Co-authored-by: meili-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix part of the phpmd issues (most of the simpler ones) like long variable names, too many lines in the same method, and useless else conditions.