-
Notifications
You must be signed in to change notification settings - Fork 9
GHA build to replace (unused) CircleCI #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GHA to build debug APK on branches/main and upload signed artifacts to a release when creating a release in GHA. Version number management remains manual. The release upload can't really be tested without running a release so we'll tag a v3.0.8 after merging this to check all's well.
1884bf2
to
22001cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the signed bundle and debug APK, looks good to me
I think we should probably split release and build into their own yml files so they can be triggered separately and don't need to use "if". That way we'll lose the "skipped" part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, made a tweak in the README.md
GHA to build debug APK on branches/main and upload signed artifacts to a release when creating a release in GHA. Version number management remains manual.
The release upload can't really be tested without running a release so we'll tag a v3.0.8 after merging this to check all's well. That and all future releases should be created via the GH releases UI creating the corresponding tag that way too.