Skip to content

GHA build to replace (unused) CircleCI #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

microbit-matt-hillsdon
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon commented Apr 7, 2024

GHA to build debug APK on branches/main and upload signed artifacts to a release when creating a release in GHA. Version number management remains manual.

The release upload can't really be tested without running a release so we'll tag a v3.0.8 after merging this to check all's well. That and all future releases should be created via the GH releases UI creating the corresponding tag that way too.

GHA to build debug APK on branches/main and upload signed artifacts to a
release when creating a release in GHA.  Version number management
remains manual.

The release upload can't really be tested without running a release so
we'll tag a v3.0.8 after merging this to check all's well.
@microbit-matt-hillsdon microbit-matt-hillsdon changed the title [WIP] GitHub actions build GHA build to replace (unused) CircleCI Apr 8, 2024
@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review April 8, 2024 10:19
Copy link
Collaborator

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the signed bundle and debug APK, looks good to me

@microbit-matt-hillsdon
Copy link
Author

I think we should probably split release and build into their own yml files so they can be triggered separately and don't need to use "if". That way we'll lose the "skipped" part.

Copy link
Collaborator

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, made a tweak in the README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants