Skip to content

Fix stray \r. Remove unused string. #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

microbit-matt-hillsdon
Copy link

The \r displays as 'r'.

Closes #12

The \r displays as 'r'.

Closes #12
@microbit-matt-hillsdon
Copy link
Author

Mainly fixing this so my test release based on #52 is marginally more interesting!

@microbit-matt-hillsdon
Copy link
Author

microbit-matt-hillsdon commented Apr 8, 2024

Checked the apk built by GHA and the 'r' is gone and the line break remains.

Copy link
Collaborator

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via APK, LGTM

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 273350b into main Apr 8, 2024
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the fix-strings branch April 8, 2024 12:32
@martinwork
Copy link
Collaborator

Fixes #12?

@microbit-matt-hillsdon
Copy link
Author

Fixes #12?

Yep that's in the main comment so it's been closed now the PR is merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stray 'r` in Delete project message
3 participants