-
Notifications
You must be signed in to change notification settings - Fork 10
Add support for data logging #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -215,4 +215,31 @@ mergeInto(LibraryManager.library, { | |
mp_js_hal_audio_is_expression_active: function () { | ||
return board.audio.isSoundExpressionActive(); | ||
}, | ||
|
||
mp_js_hal_log_delete: function (full_erase) { | ||
board.dataLogging.delete(); | ||
}, | ||
|
||
mp_js_hal_log_set_mirroring: function (serial) { | ||
board.dataLogging.delete(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope. |
||
}, | ||
|
||
mp_js_hal_log_set_timestamp: function (period) { | ||
board.dataLogging.setTimestamp(period); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should there be some kind of conversion here? |
||
}, | ||
|
||
mp_js_hal_log_begin_row: function () { | ||
board.dataLogging.beginRow(); | ||
return 0; | ||
}, | ||
|
||
mp_js_hal_log_end_row: function () { | ||
board.dataLogging.endRow(); | ||
return 0; | ||
}, | ||
|
||
mp_js_hal_log_data: function (key, value) { | ||
board.dataLogging.setLogData(UTF8ToString(key), UTF8ToString(value)); | ||
return 0; | ||
}, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to radio, I'm unsure whether this fits the sensor model. Let's see how radio works out first.