Add support for data logging #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
src/jshal.js
Outdated
| }, | ||
|
|
||
| mp_js_hal_log_set_mirroring: function (serial) { | ||
| board.dataLogging.delete(); |
There was a problem hiding this comment.
Is this right?
There was a problem hiding this comment.
Nope. 26e9c8b.
| value: string | number; | ||
| } | ||
|
|
||
| export class DataLoggingSensor extends Sensor { |
There was a problem hiding this comment.
Similarly to radio, I'm unsure whether this fits the sensor model. Let's see how radio works out first.
| }, | ||
|
|
||
| mp_js_hal_log_set_timestamp: function (period) { | ||
| board.dataLogging.setTimestamp(period); |
There was a problem hiding this comment.
Should there be some kind of conversion here?
|
Reworked into #41 after the API change. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.