-
Notifications
You must be signed in to change notification settings - Fork 10
Initial data logging implementation. #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think the default timestamp should be milliseconds, but the example logs out seconds without changing the timestamp? |
This is correct (due to set_labels call) but the docs are wrong. Raised microbit-foundation/python-editor-v3#920 |
c4dc421
to
e13e88e
Compare
Similar approach to radio. Add tests with vitest. At some point we'll try to switch to vite to build this so pick an aligned test runner.
e13e88e
to
1077d2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This can now also be reviewed via the UI PR: microbit-foundation/python-editor-v3#922