Skip to content

Initial data logging implementation. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Conversation

microbit-matt-hillsdon
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon commented Aug 30, 2022

This can now also be reviewed via the UI PR: microbit-foundation/python-editor-v3#922

@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit fd530aa
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/630f3f154f7e850008d359ef
😎 Deploy Preview https://deploy-preview-41--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@microbit-robert
Copy link
Contributor

I think the default timestamp should be milliseconds, but the example logs out seconds without changing the timestamp?

@microbit-matt-hillsdon
Copy link
Contributor Author

I think the default timestamp should be milliseconds, but the example logs out seconds without changing the timestamp?

This is correct (due to set_labels call) but the docs are wrong. Raised microbit-foundation/python-editor-v3#920

Similar approach to radio.

Add tests with vitest. At some point we'll try to switch to vite to
build this so pick an aligned test runner.
Copy link
Contributor

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit a5b2a69 into main Aug 31, 2022
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the alt-data-logging branch August 31, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants