Add "config" message for translation #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to decide whether we update text via a message or URL params but identifying the strings is a good start.
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
microbit-matt-hillsdon
changed the title
microbit-matt-hillsdon
changed the title
|
Test via $("iframe").contentWindow.postMessage({kind: "config", language: "fr", translations: {"button-a": "Button Aaah"}}) |
|
Can now be tested via https://github.com/microbit-foundation/python-editor-next/pull/925/files#diff-e177938198aa5ab3756df5b064edec860e613791aa48e83d2fe97837302ff3c1R36-R39 but it's not very convincing as there's no actual translation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left color on the URL as it's needed immediately to get the correct visual.