[DRAFT DO NOT MERGE] Add support for simulator data logging #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
microbit-robert
commented
Aug 22, 2022
| @@ -89,7 +89,7 @@ const Simulator = ({ | |||
| ref={ref} | |||
| as="iframe" | |||
| // This needs changing before we remove the flag. | |||
| src={`https://stage-python-simulator.microbit.org/simulator.html?color=${encodeURIComponent( | |||
| src={`https://deploy-preview-36--distracted-dubinsky-fd8a42.netlify.app/simulator.html?color=${encodeURIComponent( | |||
There was a problem hiding this comment.
Change this back before merging!
| export interface DataLoggingSensor { | ||
| type: "log"; | ||
| id: string; | ||
| value: [LogData[]]; |
There was a problem hiding this comment.
Do we mean a singleton array here?
There was a problem hiding this comment.
It's currently not, due to some difficulties I was having, but it probably should be.
microbit-robert
commented
Aug 22, 2022
| <HStack justifyContent="space-between" width="100%"> | ||
| {icon} | ||
| <Text>{Math.max(sensor.value.length - 1, 0)} rows</Text> | ||
| <Button size="sm">Download</Button> |
There was a problem hiding this comment.
Currently does nothing.
|
Superseded by #922 which built on this branch. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.