Skip to content

Ignore FS errors from stat() in some cases. #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Feb 10, 2020

(for #9901)

The earlier FS code ignored errors in a couple of situations. Recent changes inadvertently stopped ignoring them. This change restores the earlier behavior (and adds logging of the errors).

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • [ ] Test plan is updated as appropriate.
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [ ] The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ericsnowcurrently ericsnowcurrently removed the request for review from kimadeline February 10, 2020 18:59
@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #10021 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10021      +/-   ##
==========================================
+ Coverage   61.19%   61.21%   +0.02%     
==========================================
  Files         564      564              
  Lines       30147    30152       +5     
  Branches     4561     4561              
==========================================
+ Hits        18448    18458      +10     
+ Misses      10667    10659       -8     
- Partials     1032     1035       +3
Impacted Files Coverage Δ
src/client/common/platform/fileSystem.ts 77.21% <100%> (+1.78%) ⬆️
src/client/constants.ts 80% <0%> (ø) ⬆️
src/client/sourceMapSupport.ts 80.43% <0%> (+2.17%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead69d5...b0be9b2. Read the comment docs.

@ericsnowcurrently ericsnowcurrently merged commit 0f6a003 into microsoft:master Feb 10, 2020
@ericsnowcurrently ericsnowcurrently deleted the fix-9901-fs-perm-errors branch February 10, 2020 20:21
ericsnowcurrently added a commit that referenced this pull request Feb 10, 2020
(for #9901)

The earlier FS code ignored errors in a couple of situations. Recent changes inadvertently stopped ignoring them. This change restores the earlier behavior (and adds logging of the errors).

This is a backport of #10021.
@lock lock bot locked as resolved and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants