Skip to content

Ignore FS errors from stat() in some cases. #10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ericsnowcurrently
Copy link

(for #9901)

The earlier FS code ignored errors in a couple of situations. Recent changes inadvertently stopped ignoring them. This change restores the earlier behavior (and adds logging of the errors).

This is a backport of #10021.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Feb 10, 2020

Codecov Report

Merging #10032 into release-2020.02 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.02   #10032      +/-   ##
===================================================
+ Coverage             61.2%   61.22%   +0.01%     
===================================================
  Files                  564      564              
  Lines                30083    30088       +5     
  Branches              4551     4551              
===================================================
+ Hits                 18411    18420       +9     
+ Misses               10642    10636       -6     
- Partials              1030     1032       +2
Impacted Files Coverage Δ
src/client/common/platform/fileSystem.ts 77.87% <100%> (+1.78%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (ø) ⬆️
src/client/linters/pydocstyle.ts 88.88% <0%> (ø) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (ø) ⬆️
src/client/common/process/proc.ts 15.21% <0%> (ø) ⬆️
src/client/sourceMapSupport.ts 80.43% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fee5c...cbb13e2. Read the comment docs.

@ericsnowcurrently ericsnowcurrently merged commit 7a26421 into microsoft:release-2020.02 Feb 10, 2020
@ericsnowcurrently ericsnowcurrently deleted the fix-9901-fs-perm-errors branch February 10, 2020 22:50
@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants