Interactive Window input box tweaks #10029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
commented
Feb 10, 2020
| ...arg.prevState, | ||
| activateCount: arg.prevState.activateCount + 1 | ||
| }; | ||
| return focusPending(arg.prevState); |
There was a problem hiding this comment.
Both do the same thing currently, but I was keeping them as they represent different actions.
IanMatthewHuff
requested review from
DonJayamanne,
rchiodo and
DavidKutu
and removed request for
DonJayamanne
DonJayamanne
approved these changes
Feb 10, 2020
DavidKutu
approved these changes
Feb 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #10029 +/- ##
==========================================
- Coverage 61.19% 61.17% -0.02%
==========================================
Files 564 564
Lines 30147 30173 +26
Branches 4561 4567 +6
==========================================
+ Hits 18448 18458 +10
- Misses 10667 10680 +13
- Partials 1032 1035 +3
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9282
Doing 1, 5, and 6 from the VSCode list.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).